-
Notifications
You must be signed in to change notification settings - Fork 156
docs: Improve examples/cdk/README.md #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
requested changes
Jan 14, 2022
packages/metrics/tests/e2e/standardFunctions.test.MyFunction.ts
Outdated
Show resolved
Hide resolved
@dreamorosi comments addressed in bd217ef |
dreamorosi
reviewed
Jan 14, 2022
dreamorosi
approved these changes
Jan 17, 2022
flochaz
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Write a dedicated readme that explains how to deploy and interact with the CDK examples. Also update stack identifiers, e.g. CdkAppStack, to more specific ones, e.g. 'LambdaPowertoolsTypeScript-ExamplesCdkStack', to consider users that are deploying this stack amongst others into their accounts.
The current README is just the default CDK TS readme and is therefore not helpful.
No dependencies for this change.
How to verify this change
Related issues, RFCs
#XXXXX
#ZZZZZ
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.